vvysotskyi commented on a change in pull request #2278:
URL: https://github.com/apache/drill/pull/2278#discussion_r675621464
##########
File path:
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java
##########
@@ -29,6 +31,13 @@
// DO NOT include enabled status in equality and hash
// comparisons; doing so will break the plugin registry.
private Boolean enabled;
+ protected final Integer reconnectRetries;
Review comment:
Some plugins might not use this property, or it may be invalid for them,
for example, there is no reason to use it for `sys` or `cp` plugins, but they
all will have it... If someone else will be willing to use it in one more
plugin, it is possible to move it to the common parent class, but for now, it
is better to leave it in Splunk config only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
