Leon-WTF commented on a change in pull request #2290:
URL: https://github.com/apache/drill/pull/2290#discussion_r689078668
##########
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
##########
@@ -53,11 +54,12 @@
try (Connection con = source.getConnection();
ResultSet set = con.getMetaData().getCatalogs()) {
connectionSchemaName = con.getSchema();
- while (set.next()) {
- final String catalogName = set.getString(1);
- CapitalizingJdbcSchema schema = new CapitalizingJdbcSchema(
- getSchemaPath(), catalogName, source, dialect, convention,
catalogName, null, caseSensitive);
- schemaMap.put(schema.getName(), schema);
+ if
(!ClickhouseConstant.PRODUCT_NAME.equals(con.getMetaData().getDatabaseProductName()))
{
Review comment:
I have added JdbcSchemaFactory and JdbcSqlGenerator, please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
