cgivre commented on a change in pull request #2290: URL: https://github.com/apache/drill/pull/2290#discussion_r692577755
########## File path: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcSchemaFactory.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.jdbc; + +import org.apache.calcite.schema.SchemaPlus; +import org.apache.drill.exec.store.SchemaConfig; +import org.apache.drill.exec.store.jdbc.clickhouse.ClickhouseCatalogSchema; + +public class JdbcSchemaFactory { + private final JdbcStoragePlugin plugin; + + public JdbcSchemaFactory (JdbcStoragePlugin plugin) { + this.plugin = plugin; + } + + public void registerSchemas(SchemaConfig config, SchemaPlus parent) { + if (plugin.getConfig().isClickhouse()) { Review comment: @paul-rogers Alternatively, the dialect is actually stored in the Plugin file, not the config file. More good news is that there already is a method in the Plugin file: https://github.com/apache/drill/blob/39b565f112122734c080324fdcbef518ced16507/contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java#L81-L83 If I'm tracking the logic correctly, you could use this logic to get the dialect without having to modify the config at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
