cgivre commented on pull request #2270: URL: https://github.com/apache/drill/pull/2270#issuecomment-901858374
@paul-rogers Thanks for the review. I believe I addressed all your comments. I added the ability to specify a default value in the URL, as well as added a lot of new unit tests. I fixed a small bug as well with the `errorOn400` config option and added a test for that. Some of your questions made me wonder how much "misuse" we should tolerate from a user. For instance, putting the entire URL as a URL parameter... This is perhaps foolish to do that, but I didn't think there was a risk here because in order to do that, the user would have to have admin access to the plugin configuration anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
