cgivre commented on pull request #2270:
URL: https://github.com/apache/drill/pull/2270#issuecomment-902946153
> @cgivre, thanks for the many improvements. Looking pretty good. A few
minor comments.
>
> Regarding the "misuse" of query parameters: I see such "misuse" as a
feature, not a bug. Consider. Today I must create a new config for each new
URL. But, I'm lazy, so I create a "universal" config: `url="{url}"`. Now I can
hit any URL and the magic of Drill's schema-on read will figure it out,
assuming the returned data is of the right shape.
>
> The goal of the original comment was to get us to realize, "hey, this
might be useful. Lets a) document it and b) test it."
Gotcha! 👍 Makes sense. I was debating putting some sort of URL validation
on the config, but I think I'll leave it alone for the time being if you're ok
with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
