Leon-WTF commented on a change in pull request #2290:
URL: https://github.com/apache/drill/pull/2290#discussion_r702268570
##########
File path:
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java
##########
@@ -19,11 +19,9 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
-import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
-@JsonInclude(JsonInclude.Include.NON_DEFAULT)
Review comment:
Sure, this is for fixing one ut case, I have tried another way.
##########
File path:
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java
##########
@@ -19,11 +19,9 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
-import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
-@JsonInclude(JsonInclude.Include.NON_DEFAULT)
Review comment:
Got it, this is for fixing one ut case, I have tried another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
