jnturton commented on a change in pull request #2424:
URL: https://github.com/apache/drill/pull/2424#discussion_r786651480
##########
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/paginator/PagePaginator.java
##########
@@ -47,11 +44,10 @@
* @param pageSizeParam The API Query parameter which specifies how many
results per page
*/
public PagePaginator(Builder builder, int limit, int pageSize, String
pageParam, String pageSizeParam) {
- super(builder, paginationMode.PAGE, pageSize, limit > 0);
+ super(builder, paginationMode.PAGE, pageSize, limit);
this.limit = limit;
this.pageParam = pageParam;
this.pageSizeParam = pageSizeParam;
- this.paginatedUrls = buildPaginatedURLs();
currentPage = 1;
Review comment:
@cgivre While testing this PR today I encountered an API that starts
counting pages at 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
