jnturton commented on a change in pull request #2424:
URL: https://github.com/apache/drill/pull/2424#discussion_r786652254
##########
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/paginator/PagePaginator.java
##########
@@ -64,16 +60,16 @@ public PagePaginator(Builder builder, int limit, int
pageSize, String pageParam,
}
@Override
- public String next() {
- if (hasLimit) {
- return super.next();
- } else {
- return generateNextUrl();
- }
+ public boolean hasNext() {
+ return !partialPageReceived && (limit < 0 || (currentPage-1) * pageSize <
limit);
Review comment:
@paul-rogers I can't see that LIMIT 0 is disallowed. This `hasNext()`
method above returns false immediately in this case and 0 records are returned
for the query, is that not correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
