jnturton opened a new pull request #2460:
URL: https://github.com/apache/drill/pull/2460


   # [DRILL-8134](https://issues.apache.org/jira/browse/DRILL-8134): Cannot 
query Parquet INT96 columns as timestamps
   
   ## Description
   
   As of Drill 1.19 some Parquet readers column contained code to position the 
value vector write buffer index after a read pass, while some did not.  The 
Parquet v2 PR added write buffer positioning to the cases that were missing it, 
but failed to cater for the fact that INT96 timestamps are downcast to 64 bit 
timestamps.  This PR removes all of this write buffer positioning (and 
mispositioning) since testing indicates that Drill's value vector write paths 
advance the write buffer index to correct place already.
    
   ## Documentation
   N/A
   
   ## Testing
   ParquetTestWriter#testSparkParquetBinaryAsTimeStamp_DictChange
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to