vdiravka commented on pull request #2460: URL: https://github.com/apache/drill/pull/2460#issuecomment-1040442325
I like PRs with code removal :) They certainly mean the code starts to be simpler and cleaner. The changes looks good to me. Just please fix setting `system` options in `TestParquetWriter`#`compareParquetReadersColumnar` method. It should be `session` level. Then `testSparkParquetBinaryAsTimeStamp_DictChange` and `testTPCHReadWriteLz4` will show DRILL-8134 bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
