cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829066804
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/HttpUtils.java ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.util; Review comment: So... originally, I started work with this in the `udfs` package. I thought it would be a good idea to make a Drill utils class that can be accessed anywhere that has all the associated methods for making http requests. Then, I ended up moving the UDF to `storage-http` because it needed the http storage config and never relocated it. If you feel strongly about it, I can move all those methods to `SimpleHttp` and eliminate the class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
