cgivre commented on a change in pull request #2496: URL: https://github.com/apache/drill/pull/2496#discussion_r829656793
########## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.http.udfs; + +import io.netty.buffer.DrillBuf; +import org.apache.drill.exec.expr.DrillSimpleFunc; +import org.apache.drill.exec.expr.annotations.FunctionTemplate; +import org.apache.drill.exec.expr.annotations.Output; +import org.apache.drill.exec.expr.annotations.Param; +import org.apache.drill.exec.expr.annotations.Workspace; +import org.apache.drill.exec.server.DrillbitContext; +import org.apache.drill.exec.server.options.OptionManager; +import org.apache.drill.exec.vector.complex.reader.FieldReader; +import org.apache.drill.exec.vector.complex.writer.BaseWriter.ComplexWriter; + +import javax.inject.Inject; + +public class HttpHelperFunctions { + + @FunctionTemplate(names = {"http_get_url", "httpGetUrl"}, + scope = FunctionTemplate.FunctionScope.SIMPLE, + isVarArg = true) + public static class HttpGetFunction implements DrillSimpleFunc { + + @Param + FieldReader[] inputReaders; + + @Output + ComplexWriter writer; + + @Inject + OptionManager options; + + @Inject + DrillBuf buffer; + + @Workspace + org.apache.drill.exec.vector.complex.fn.JsonReader jsonReader; + + @Override + public void setup() { + jsonReader = new org.apache.drill.exec.vector.complex.fn.JsonReader.Builder(buffer) + .defaultSchemaPathColumns() + .readNumbersAsDouble(options.getOption(org.apache.drill.exec.ExecConstants.JSON_READ_NUMBERS_AS_DOUBLE).bool_val) + .allTextMode(options.getOption(org.apache.drill.exec.ExecConstants.JSON_ALL_TEXT_MODE).bool_val) + .enableNanInf(options.getOption(org.apache.drill.exec.ExecConstants.JSON_READER_NAN_INF_NUMBERS).bool_val) + .build(); + } + + @Override + public void eval() { + if (inputReaders.length > 0) { + // Get the URL + FieldReader urlReader = inputReaders[0]; + String url = urlReader.readObject().toString(); Review comment: I did this for the UDF that accepts a storage plugin as the first argument, but not the first one. The reason being that the there are some APIs which return URLs and I could imagine a use case where a user might want to generate a list of URLs then call them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
