hboutemy commented on a change in pull request #2484:
URL: https://github.com/apache/drill/pull/2484#discussion_r841040253
##########
File path: pom.xml
##########
@@ -548,67 +547,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>pl.project13.maven</groupId>
- <artifactId>git-commit-id-plugin</artifactId>
Review comment:
yes, that's expected to be done like this while releasing: no choice,
the beginning of the release process is a source control. It has been cvs, then
svn, now git, perhaps something else in the future.
the fact is that when voting, the source tarball is what is registered at
Apache level, with distribution area, because it's the same format for years
and for foreseeable future
and sadly, if you have such dependency on Git, you can't rebuild from that
official source tarball and get the same output
that's why I propose to get the best of the 2 worlds:
- when building a SNAPSHOT, yes, use that Git binding because it gives you
useful details
- when building a release, just don't use that Git binding because it causes
that issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
