jnturton commented on a change in pull request #2484:
URL: https://github.com/apache/drill/pull/2484#discussion_r841167111
##########
File path: pom.xml
##########
@@ -548,67 +547,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>pl.project13.maven</groupId>
- <artifactId>git-commit-id-plugin</artifactId>
Review comment:
@hboutemy would it be sufficient, as @vvysotskyi proposed, for us to
remove from the generated git.properties file those of the plugin's outputs
that are not are not reproducible. I.e. kill lines such as these?
```
│ -git.build.host=jtpc
│ -git.build.time=22.02.2022 @ 20\:20\:27 SAST
│ +git.build.host=c23e344f8445
│ +git.build.time=26.02.2022 @ 17\:58\:09 UTC
│ git.build.user.email=
│ git.build.user.name=
```
In general, I'm a fan of the idea of being to build from only a source
tarball with no dependency on the VCS _de jour_ but on the other hand,
adjusting this git-commit-id plugin looks less disruptive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
