[GitHub] [drill] vvysotskyi commented on a diff in pull request #2632: DRILL-8283: Add a configurable recursive file listing size limit

[GitBox]

vvysotskyi commented on code in PR #2632:
URL: https://github.com/apache/drill/pull/2632#discussion_r954723117


##########
exec/java-exec/src/main/java/org/apache/drill/exec/util/FileSystemUtil.java:
##########
@@ -302,12 +332,32 @@ protected List<FileStatus> compute() {
       List<RecursiveListing> tasks = new ArrayList<>();
 
       try {
-        for (FileStatus status : fs.listStatus(path, filter)) {
+        FileStatus[] dirFs = fs.listStatus(path, filter);
+        if (recursiveListingMaxSize > 0 && fileCounter.addAndGet(dirFs.length) 
> recursiveListingMaxSize) {
+          throw UserException

Review Comment:
   This code is executed within fork join pool, and if error suppression flag 
is enabled, it will call task.fork(). Can we somehow stop executing all tasks 
for the case when count is reached?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org