jnturton commented on code in PR #2632:
URL: https://github.com/apache/drill/pull/2632#discussion_r954914617
##########
exec/java-exec/src/main/java/org/apache/drill/exec/util/FileSystemUtil.java:
##########
@@ -42,6 +47,12 @@ public class FileSystemUtil {
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(FileSystemUtil.class);
+ private static int recursiveListingMaxSize;
+
+ static {
+ recursiveListingMaxSize =
DrillConfig.create().getInt(ExecConstants.RECURSIVE_FILE_LISTING_MAX_SIZE);
+ }
Review Comment:
That it might be a heavyweight duplication of work was bothering me enough
that I went and timed it. It takes about ~100ms when I start embedded Drill
locally. That's just enough to make me wonder if it's worth trying to redesign
this stuff so that it loads from an existing instance of DrillConfig instead of
constructing its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
