cgivre commented on code in PR #2641:
URL: https://github.com/apache/drill/pull/2641#discussion_r964729134


##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -189,6 +191,8 @@ public void eval() {
         rowWriter.start();
         if (jsonLoader.parser().next()) {
           rowWriter.save();
+        } else {

Review Comment:
   Should we explicitly close the `results` `InputStream` here as well?  Would 
mind testing this on a query that produces multiple batches?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to