jnturton commented on code in PR #2641:
URL: https://github.com/apache/drill/pull/2641#discussion_r964747549
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -189,6 +191,8 @@ public void eval() {
rowWriter.start();
if (jsonLoader.parser().next()) {
rowWriter.save();
+ } else {
Review Comment:
@cgivre
1. The JsonLoader closes the input streams it's been working off of when it
is closed so I don't think so.
2. Multiple batch datasets do not work with these UDFs yet from what I
recall? I think @vdiravka continues to work on that, perhaps he can comment on
the closing of the JsonLoader here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
