jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r201163578
##########
File path: common/src/main/java/io/druid/math/expr/ExprEval.java
##########
@@ -99,10 +98,10 @@ public Object value()
return value;
}
- public boolean isNull()
Review comment:
nit: I think it's better to call this method rather than doing `value() ==
null` in call sites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org
