jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r203510498
##########
File path:
extensions-core/lookups-cached-single/src/main/java/io/druid/server/lookup/LoadingLookup.java
##########
@@ -62,15 +63,19 @@ public LoadingLookup(
@Override
- public String apply(final String key)
+ public String apply(@Nullable final String key)
{
- if (key == null) {
+ String keyEquivalent = NullHandling.nullToEmptyIfNeeded(key);
Review comment:
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org
