leventov commented on a change in pull request #5957: Various changes
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r202521148
 
 

 ##########
 File path: 
processing/src/main/java/io/druid/query/aggregation/JavaScriptAggregatorFactory.java
 ##########
 @@ -353,6 +354,15 @@ public double aggregate(final double current, final 
BaseObjectColumnValueSelecto
         return Context.toNumber(res);
       }
 
+      private Object[] arrayToObjectArray(Object array)
+      {
+        final Object[] objectArray = new Object[Array.getLength(array)];
+        for (int j = 0; j < Array.getLength(array); j++) {
 
 Review comment:
   Thanks, extracted a variable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to