leventov commented on a change in pull request #5957: Various changes
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r202521197
##########
File path:
processing/src/test/java/io/druid/collections/bitmap/BitmapBenchmark.java
##########
@@ -73,7 +73,7 @@ protected static ImmutableConciseSet
makeOffheapConcise(ImmutableConciseSet conc
conciseCount++;
final ByteBuffer buf = ByteBuffer.allocateDirect(bytes.length).put(bytes);
buf.rewind();
- return new ImmutableConciseSet(buf);
+ return new ImmutableConciseSet(buf.asIntBuffer());
Review comment:
I removed one of the constructors, don't remember for what reason, maybe to
reduce ambiguity. I don't see that one version is better than another.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
