leventov commented on a change in pull request #5958: Part 2 of changes for SQL
Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522407
##########
File path: processing/src/main/java/io/druid/query/topn/TopNMapFn.java
##########
@@ -56,14 +56,10 @@
return longVal == null ? DimensionHandlerUtils.ZERO_LONG : longVal;
};
- private static Function<Object, Object> FLOAT_TRANSFORMER = input -> {
- final Float floatVal = DimensionHandlerUtils.convertObjectToFloat(input);
- return floatVal == null ? DimensionHandlerUtils.ZERO_FLOAT : floatVal;
- };
- private static Function<Object, Object> DOUBLE_TRANSFORMER = input -> {
- final Double doubleValue =
DimensionHandlerUtils.convertObjectToDouble(input);
- return doubleValue == null ? DimensionHandlerUtils.ZERO_DOUBLE :
doubleValue;
- };
+ private static Function<Object, Object> FLOAT_TRANSFORMER = input ->
DimensionHandlerUtils.convertObjectToFloat(input);
Review comment:
Could be a method reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
