leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522236
########## File path: processing/src/main/java/io/druid/query/filter/ValueGetter.java ########## @@ -27,5 +29,7 @@ // converted to strings. We should also add functions // for these and modify ColumnComparisonFilter to handle // comparing Long and Float columns to eachother. + // Returns null when the underlying Long/Float value is null. Review comment: Not addressed: https://github.com/apache/incubator-druid/pull/5452#discussion_r200339349 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
