nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811628
##########
File path: sql/src/main/java/io/druid/sql/calcite/planner/DruidRexExecutor.java
##########
@@ -84,7 +84,7 @@ public void reduce(
if (sqlTypeName == SqlTypeName.BOOLEAN) {
literal = rexBuilder.makeLiteral(exprResult.asBoolean(),
constExp.getType(), true);
} else if (sqlTypeName == SqlTypeName.DATE) {
- if (!constExp.getType().isNullable() && exprResult.isNull()) {
+ if (!constExp.getType().isNullable() && exprResult.isNumericNull()) {
Review comment:
It is possible for an expression to have a non-null String value but it can
return null when parsed as a primitive long/float/double.
ExprEval.isNumericNull checks whether the parsed primitive value is null or
not.
Added comment to code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
