nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204815667
##########
File path: common/src/main/java/io/druid/math/expr/ExprEval.java
##########
@@ -99,10 +98,10 @@ public Object value()
return value;
}
- public boolean isNull()
Review comment:
this method is replaced with isNumericNull as that is what we need to check
for Expressions.
isNumericNull will check whether the primitive long/float/double equivalent
is null or not.
It is possible for an expression to have a non-null String value but it can
return null when parsed as a primitive long/float/double.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
