jihoonson commented on a change in pull request #5958: Part 2 of changes for 
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204916166
 
 

 ##########
 File path: 
extensions-core/lookups-cached-single/src/test/java/io/druid/server/lookup/LoadingLookupTest.java
 ##########
 @@ -43,13 +44,20 @@
   public void testApplyEmptyOrNull()
   {
     Assert.assertEquals(null, loadingLookup.apply(null));
-    Assert.assertEquals(null, loadingLookup.apply(""));
+    if (NullHandling.sqlCompatible()) {
+      // empty string should also have same behavior
+      Assert.assertEquals(null, loadingLookup.apply(""));
+    }
   }
 
   @Test
   public void testUnapplyNull()
   {
-    Assert.assertEquals(Collections.EMPTY_LIST, loadingLookup.unapply(null));
+    if (NullHandling.sqlCompatible()) {
+      Assert.assertEquals(Collections.emptyList(), 
loadingLookup.unapply(null));
+    } else {
+      Assert.assertEquals(null, loadingLookup.unapply(null));
 
 Review comment:
   `Assert.assertNull()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

Reply via email to