On Fri, 18 Jan 2019 at 08:19, Don Bowman <d...@agilicus.com> wrote:
> > So I have a Dockerfile which i think will work well. Before I commit and > create the PR can I ask for some direction? > Would we use this as > > a: the Dockerfile is in the source tree, and does a 'COPY .' into the > container to build? This is what I did for > https://github.com/fluent/fluent-bit. It makes it very simple to build > the docker container as a developer, but also as part of the travis > pipeline or the dockerhub pipeline.... This would mean replacing the 'git > clone/checkout' in the below. > b: The Dockerfile is standalone, it does a clone of the repo (as below). > This is not as convenient for a dev (you need to have pushed) nor for the > other pipelines, but it does allow for a single point in time release. > > For the 'config', what i have gone for is any druid_XXX env variable is > converted to druid.xxx config in _common/properties or service/properties. > > > I have created a PR (https://github.com/apache/incubator-druid/pull/6896) using option 'a' above. Comments welcome!.
