To foster calmness, respect, and consideration of people's busy schedules I
suggest the following etiquette:

- When someone showed up in a PR and left some review comments, but didn't
explicitly approved the PR, poke them with comments like "@username do you
have more comments?" not sooner than in one week since they left the last
review comment.
- Poke people no more frequently than once per week.
- If there are enough approvals, a PR could be merged not sooner than in
two weeks since they left the last review comment.
- If someone created a valuable PR but then stopped responding to review
comments and there are conflicts or tests/CI don't pass, a PR could be
recreated by another person not sooner than in three weeks since the
author's last activity in the PR. Their authorship should be preserved by
cherry-picking their commits, squashing them locally, rebasing on top of
current upstream master, creating a new PR and choosing "Rebase and merge"
option when merging the new PR instead of the default "Squash and merge".

Reply via email to