codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option URL: https://github.com/apache/incubator-dubbo/pull/1380#issuecomment-367338110 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=h1) Report > Merging [#1380](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f4bd1b5f2cd54a7fd4944944f94d38bc5a2b1730?src=pr&el=desc) will **decrease** coverage by `2.61%`. > The diff coverage is `4.54%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1380 +/- ## ========================================== - Coverage 32.16% 29.54% -2.62% ========================================== Files 682 685 +3 Lines 32972 35910 +2938 Branches 6597 6990 +393 ========================================== + Hits 10604 10610 +6 - Misses 20473 23406 +2933 + Partials 1895 1894 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...java/com/alibaba/dubbo/demo/ThriftDemoService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2RlbW8vVGhyaWZ0RGVtb1NlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | | | [...om/alibaba/dubbo/demo/provider/ThriftProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnRQcm92aWRlci5qYXZh) | `0% <0%> (ø)` | | | [...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `20.81% <0%> (-0.26%)` | :arrow_down: | | [...om/alibaba/dubbo/demo/provider/ThriftDemoImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnREZW1vSW1wbC5qYXZh) | `0% <0%> (ø)` | | | [...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdENvZGVjLmphdmE=) | `3.23% <2.22%> (-0.11%)` | :arrow_down: | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `39.53% <50%> (+0.09%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | :arrow_down: | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `73.14% <0%> (-2.78%)` | :arrow_down: | | ... and [5 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=footer). Last update [f4bd1b5...3e38f9c](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
