codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option URL: https://github.com/apache/incubator-dubbo/pull/1380#issuecomment-367338110 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=h1) Report > Merging [#1380](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a2a7706a07897bc7d0dc79923dc724159766da78?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `5.76%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1380 +/- ## ============================================ - Coverage 35.42% 35.39% -0.03% - Complexity 3777 3778 +1 ============================================ Files 628 628 Lines 30994 31012 +18 Branches 5456 5462 +6 ============================================ - Hits 10979 10978 -1 - Misses 18124 18142 +18 - Partials 1891 1892 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `20.81% <0%> (-0.26%)` | `18 <0> (ø)` | | | [...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdENvZGVjLmphdmE=) | `2.95% <2.22%> (-0.1%)` | `5 <0> (ø)` | | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `39.62% <50%> (+0.09%)` | `43 <1> (+1)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-11.12%)` | `5% <0%> (-1%)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `74.76% <0%> (-1.87%)` | `7% <0%> (ø)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `54.43% <0%> (-1.27%)` | `12% <0%> (-1%)` | | | [...n/java/com/alibaba/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL0pWTVV0aWwuamF2YQ==) | `79.62% <0%> (+7.4%)` | `15% <0%> (+2%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=footer). Last update [a2a7706...905a777](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
