zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936906
 
 

 ##########
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
 ##########
 @@ -60,7 +65,7 @@
  */
 public class ReferenceAnnotationBeanPostProcessor extends 
InstantiationAwareBeanPostProcessorAdapter
         implements MergedBeanDefinitionPostProcessor, PriorityOrdered, 
ApplicationContextAware, BeanClassLoaderAware,
-        DisposableBean {
+        DisposableBean, ApplicationListener<ContextRefreshedEvent> {
 
 Review comment:
   I always think that @EnableDubbo (basepackage="com.xxx") since it supports 
packet scanning, should avoid having the user repeatedly configure the same 
@ComponentScan(basepackage="com.xxx").

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to