Thx, I have seen the issue before. The pr is try to fix a part of problem(part of DefaultFuture).
The other problem,HeartBeat, I think Heartbeat components can also use HashedWheelTimer. In the future, HeartBeatTasks will be deprecated. Heatbeat components will use Netty's ChannelHandler. These Handlers will be registered in the pipeline of each Channel to check expiration time(read and write). I will try to modify it.Maybe learn from the heatbeat components in jupiter[1] I have changed my name in English, it might be effected soon.😁 [1]https://github.com/fengjiachun/Jupiter 2018-06-22 10:48 GMT+08:00 jun liu <[email protected]>: > Hi 修宇航, > > Good job! > > I also find that the heartbeat mechanism in Dubbo can be optimized using > HashedWheelTimer. Here’s a issue reporting reporting this: > https://github.com/apache/incubator-dubbo/issues/1888. > Do you think it’s necessary? If you think the same, would you mind send a > PR for this issue? > > BTW, would you mind change your email show name to English? > > Best regards, > Jun > > > On 21 Jun 2018, at 3:34 PM, 修宇航 <[email protected]> wrote: > > > > Hi all, > > > > The old way to deal timeout future is view all the future. > > > > The better way is to use HashedWheelTimer like Netty , it can deal the > > timeout futures more directly, it will decrease circulate times and check > > times as my title say. > > > > The HashedWheelTimer impl will be transplanted by Netty (it will have a > > Netty license header!). > > > > About the HashedWheelTimer [1]. > > > > [1]https://netty.io/4.0/api/io/netty/util/HashedWheelTimer.html > >
