The website is really cool. I also tested mobile phone view, looks good.
I have a question about how this website will work. I guess the workflow is we update docs in repo and travis will run npm command to build it, then update latest files to gh-pages? Regards, Yunkun On 2018/07/02 06:57:38, Ian Luo <[email protected]> wrote: > I also played around this PR a little bit. It looks far beyond the current > design we are adopting, and it's more convenient for us to write articles > in its blog section. > > +1 to merge a.s.a.p so that we could ask all to focus on contributing > contents. > > Thanks, > -Ian. > > On Sun, Jul 1, 2018 at 3:53 PM Huxing Zhang <[email protected]> wrote: > > > Hi All, > > > > The new design of Dubbo website has been discussed[1] for several days. > > > > Today we've received a pull request for the new website implementation[2]. > > > > I have checked the implementation locally, it has everything we > > discussed and it looks good to me. > > > > Some details: > > > > * I can run it simply by click the index.html file on the root directory. > > * I can build from the given instructions > > * Home/docs/blogs/community page works for me > > * I can switch between Chinese and English > > * Documentation currently only has user guide, dev guide and admin > > guide are missing. But I think it can be added later. > > * Easy for us to maintain, we only care about the markdown, and the > > framework can compile to html for us. > > * I have one concern about the SEO(search engine optimization) stuff, > > since it is a single page web application, I am not sure whether the > > blogs and documentation can be correctly indexed by the search engine. > > > > How do you guys think? > > > > [1] https://github.com/apache/incubator-dubbo-website/issues/12 > > [2] https://github.com/apache/incubator-dubbo-website/pull/13 > > > > -- > > Best Regards！ > > Huxing > > >
