Just noticed as this is PR is release to dubbo-website, so was not sure whether do I need to PR email to another group. Any guide will be appreciated.
On Fri, Dec 14, 2018 at 3:18 PM Imteyaz Khan <[email protected]> wrote: > Hi, all > > I have raised the PR for dubbo website docs package name changes for the > issue id 201 > <https://github.com/apache/incubator-dubbo-website/issues/201.>. Please > find the PR details below > > https://github.com/apache/incubator-dubbo-website/pull/204 > > > > On Fri, Dec 14, 2018 at 2:01 PM Ian Luo <[email protected]> wrote: > >> cool. >> >> On Fri, Dec 14, 2018 at 1:11 PM Imteyaz Khan <[email protected]> >> wrote: >> >> > @Ian and @ huxing thanks a lot for guiding me on this, appreciate it. >> > I have created an issue for the same and the issue link is >> > https://github.com/apache/incubator-dubbo-website/issues/201. >> > >> > I am on it. >> > >> > Regards >> > Imteyaz >> > >> > On Fri, Dec 14, 2018 at 9:13 AM Ian Luo <[email protected]> wrote: >> > >> > > Khan, >> > > >> > > As Huxing said, the package name has already change to >> org.apache.dubbo >> > on >> > > branch 'master' for 2.7 releases. Pls. simply keep doc align with the >> > main >> > > trunk. >> > > >> > > Thanks, >> > > -Ian. >> > > >> > > On Fri, Dec 14, 2018 at 1:39 AM Imteyaz Khan <[email protected]> >> > > wrote: >> > > >> > > > Hi All, >> > > > As part of one of my documentation task #2935, to get some more >> > idea I >> > > > was referring to >> > > http://dubbo.apache.org/en-us/docs/dev/impls/filter.html >> > > > page and come across some content which I am pasting below >> > > > >> > > > Existing Extension >> > > > >> > > > - com.alibaba.dubbo.rpc.filter.EchoFilter >> > > > - com.alibaba.dubbo.rpc.filter.GenericFilter >> > > > - com.alibaba.dubbo.rpc.filter.GenericImplFilter >> > > > >> > > > >> > > > META-INF/dubbo/com.alibaba.dubbo.rpc.Filter： >> > > > >> > > > I believe the examples mentioned here (website) will work and people >> > will >> > > > get the information they are looking for, my query here is, is there >> > any >> > > > plan for changing it to org.apache.dubbo.* package notation or for >> now >> > it >> > > > is ok? >> > > > >> > > > Regards >> > > > Imteyaz >> > > > >> > > >> > >> >
