Hi, I think manual apply a label is fine enough for me. +1 to the original proposal
Huxing Zhang <[email protected]> 于2019年3月21日周四 下午5:58写道： > Hi, > > On Thu, Mar 21, 2019 at 3:58 PM Taosheng, Wei <[email protected]> > wrote: > > > > hi, > > how about let dubbo bot to find which pr is first-time, and then it > opens a corresponding issue to refer the pr > > > > Well I admit it is a way to solve the problem, but I looks going too far... > I am +0 to this, let's see how others think. > > > > > > > > > ------------------ Original ------------------ > > From: Huxing Zhang <[email protected]> > > Date: Thu,Mar 21,2019 3:21 PM > > To: dev <[email protected]> > > Subject: Re: Applying a label "first-time-contributor" to pull request > > > > > > > > Hi, > > > > > > > > On Thu, Mar 21, 2019 at 2:24 PM Taosheng, Wei <[email protected]> > wrote: > > > > > > It’s a good idea. Can we let the dubbo bot do this work to add the > label to prs automatically? > > > > > > > > > > I wish it could. dubbo-bot does not have write access, so the bot can > > neither be able to see it nor apply any label. > > > > > > > > > > > > > ------------------ Original ------------------ > > > From: Huxing Zhang <[email protected]> > > > Date: Thu,Mar 21,2019 1:47 PM > > > To: dev <[email protected]> > > > Subject: Re: Applying a label "first-time-contributor" to pull request > > > > > > > > > > > > Hi, > > > > > > > > > On Thu, Mar 21, 2019 at 11:20 AM Ian Luo <[email protected]> wrote: > > > > > > > > It seems unnecessary since GitHub does this for this. You can open > any pull > > > > request and will notice GitHub has nicely done this for us. > > > > > > As I stated before: > > > - Not everyone can see it, only committers can see it. You can try it > > > by opening the page in private browsing mode. > > > - It is not easy to find it, you have to open every the pull request > > > in order to see it. If someone applies this label, other won't bother > > > to do it again. > > > > > > > > > > > > > > Thanks, > > > > -Ian. > > > > > > > > On Thu, Mar 21, 2019 at 10:03 AM Huxing Zhang <[email protected]> > wrote: > > > > > > > > > Hi, > > > > > > > > > > I am thinking of applying a label called "first-time-contributor" > to > > > > > those who send pull request first time. The purpose is to better > > > > > identify those people and hope the community would act more > quickly to > > > > > those pull request in order to help them getting merged. > > > > > > > > > > Currently only those who had write access to the project will see a > > > > > 'first time contributor' tip when viewing the pull request detail > > > > > page. But there is no overview of how many pull request are 'first > > > > > time contributor'. Another issues is those who do not have write > > > > > access won't be able to see it. > > > > > > > > > > By introducing this label, I hope to attract more attention from > the > > > > > community, whether you are a committer or not, to participant more > in > > > > > reviewing those pull request (which is normally simple). > > > > > > > > > > In order to help the community to have better understanding on > this, > > > > > I've created the label and applied it for several pull requests. If > > > > > the community is not willing to see it, I can revert the change. > > > > > > > > > > -- > > > > > Best Regards！ > > > > > Huxing > > > > > > > > > > > > > > > > > -- > > > Best Regards！ > > > Huxing > > > > > > > > -- > > Best Regards！ > > Huxing > > > > -- > Best Regards！ > Huxing >
