Hi, On Wed, Jun 26, 2019 at 2:20 PM Huxing Zhang <[email protected]> wrote: > > Hi, > > On Wed, Jun 26, 2019 at 12:55 PM Daniela Morais <[email protected]> > wrote: > > > > Hi, > > > > Today I did: > > * Fixed the issues on the PR #4195 (Collect "cpu.user" metric) > > * Open a PR to refactor MetricsFilterTest ( > > https://github.com/apache/dubbo/pull/4398) > > I will take a look.
I've checked PR, it looks good to me. > > > > > I think that the next steps should be: > > 1) Make configurable what is the priority of the load balancer (between RT, > > CPU or number of inflight requests). > > 2) Select the best option based on the priority (I'm thinking of using a > > PriorityQueue) > > 3) Create unit tests and performance tests (I appreciate suggestions of a > > framework to do it. Is JUnit enough to achieve this?) > > I think JUnit is enough for unit tests. > For integration test you may checkout: https://github.com/apache/dubbo-samples > For benchmarking your code, you make check out: > https://github.com/apache/dubbo-benchmark > > > > > I appreciate your feedback! > > Thanks > > > > > > -- > > Daniela Morais > > Computer Science student at the University Of Campinas > > danielammorais.com <https://www.danielammorais.com> > > > > -- > Best Regards！ > Huxing -- Best Regards！ Huxing
