Hi, On Wed, Jul 17, 2019 at 2:35 PM Huxing Zhang <[email protected]> wrote: > > Hi, > > dubbo-config-api UT is constantly failing on my machine. > > Results : > Failed tests: > ReferenceConfigTest.testReferenceRetry:132 > Tests in error: > ReferenceConfigTest.testInjvm:57 » Rpc Fail to start server(url: > dubbo://192.1... > > ExporterSideConfigUrlTest.exporterMethodConfigUrlTest:54->verifyExporterUrlGeneration:83 > » Rpc > > ExporterSideConfigUrlTest.exporterProviderConfigUrlTest:65->verifyExporterUrlGeneration:83 > » Rpc > > ExporterSideConfigUrlTest.exporterServiceConfigUrlTest:59->verifyExporterUrlGeneration:83 > » Rpc > > InvokerSideConfigUrlTest.consumerConfUrlTest:158->verifyInvokerUrlGeneration:206 > » Rpc > InvokerSideConfigUrlTest.refConfUrlTest:163->verifyInvokerUrlGeneration:206 > » Rpc
I tried in IDEA, these test just passed. I retried a few more time in command line. It eventually passed. I vote +1 to release. > > > [YES] Are release files in correct location? > [YES] Are the digital signature and hashes correct? > [YES] Do LICENSE and NOTICE files exists? > [YES] Is the LICENSE and NOTICE text correct? > [YES] Is the NOTICE year correct? > [YES] Un-included software dependencies are not mentioned in LICENSE or > NOTICE? > [YES] License information is not mentioned in NOTICE? > Is there any 3rd party code contained inside the release? If so: > > [YES] Does the software have a compatible license? > [YES] Are all software licenses mentioned in LICENSE? > [YES] Is the full text of the licenses (or pointers to it) in LICENSE? > Is any of this code Apache licensed? Do they have NOTICE files? If so: > [YES] Have relevant parts of those NOTICE files been added to this NOTICE > file? > > [YES] Do all source files have ASF headers? > [YES] Do the contents of the release match with what's tagged in > version control? > [NO] Are there any unexpected binary files in the release? > [YES] Can you compile from source? Are the instruction clear? > > > Minor issues: > > 1. compile warning during build: > [WARNING] Some problems were encountered while building the effective > model for com.alibaba:dubbo-config-spring:jar:2.6.7 > [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' > must be unique: javax.validation:validation-api:jar -> duplicate > declaration of version (?) @ > com.alibaba:dubbo-config-spring:[unknown-version], > ~/work/apache-dubbo/svn-release/dist/dev/dubbo/2.6.7/apache-dubbo-2.6.7-source-release/dubbo-config/dubbo-config-spring/pom.xml, > line 162, column 21 > [WARNING] > [WARNING] It is highly recommended to fix these problems because they > threaten the stability of your build. > 2. When running mvn clean package on Java 11, the follow error has occurred. > > Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The > forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > > I switched to Java 8, and it works fine. It is ok 2.6.x does not > support Java 11. > > 3. binary distribution is missing. > > > > > On Mon, Jul 15, 2019 at 1:50 PM Mercy Ma <[email protected]> wrote: > > > > Hi, All > > > > This is a call for a vote to release Apache Dubbo version 2.6.7. > > > > The release candidates (there will be only source release in this version): > > https://dist.apache.org/repos/dist/dev/dubbo/2.6.7/ < > > https://dist.apache.org/repos/dist/dev/dubbo/2.6.7/> > > > > Git tag for the release: > > https://github.com/apache/dubbo/tree/dubbo-2.6.7 < > > https://github.com/apache/dubbo/tree/dubbo-2.6.7> > > > > Hash for the release tag: > > eac84b290f82bb5346a449a973315b6860a9e665 > > > > Release Notes: > > https://github.com/apache/dubbo/blob/dubbo-2.6.7/CHANGES.md < > > https://github.com/apache/dubbo/blob/dubbo-2.6.7/CHANGES.md> > > > > The artifacts have been signed with Key: 28681CB1, which can be > > found in the keys file: > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS < > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS> > > > > The vote will be open for at least 72 hours or until the necessary number of > > votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > The Apache Dubbo Team > > > > -- > Best Regards！ > > > Huxing -- Best Regards！ Huxing
