+1 to approve. I checked the items below:
[v] Are release files in correct location? [v] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [v] Is the LICENSE and NOTICE text correct? [v] Is the NOTICE year correct? [v] Un-included software dependencies are not mentioned in LICENSE or NOTICE? [v] License information is not mentioned in NOTICE? [x] Is there any 3rd party code contained inside the release? If so: [v] Does the software have a compatible license? [v] Are all software licenses mentioned in LICENSE? [v] Is the full text of the licenses (or pointers to it) in LICENSE? Is any of this code Apache licensed? Do they have NOTICE files? If so: [v] Have relevant parts of those NOTICE files been added to this NOTICE file? [v] Do all source files have ASF headers? [v] Do the contents of the release match with what's tagged in version control? [x] Are there any unexpected binary files in the release? [v] Can you compile from source? Are the instruction clear? I vote with: [v] +1 release the software [ ] +0 not sure if it should be released [ ] -1 don’t release the software because... The README.md doesn't contain the clear instructions for build and unit test, but I think this minor issue can be fixed in the next release. Regards, -Ian. On Wed, Sep 4, 2019 at 8:17 PM Stocks Alex <[email protected]> wrote: > Hello Dubbo/Dubbogo Community, > > This is a call for vote to release Apache Dubbo-go version v1.1.0. > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ > Git tag for the release: > https://github.com/apache/dubbo-go/tree/1.1 > Hash for the release tag: > e63630a5bd140da5c3643a602c8787ad264d550c > Release Notes: > https://github.com/apache/dubbo-go/blob/1.1/CHANGE.md > The artifacts have been signed with Key :0D963B35B7F1E689, which can be > found in the keys file: > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > Thanks, > The Apache Dubbo-go Team >
