Stocks Alex, You need to fix the license header issue Justin points out:
1. dubbo-go-1.1.0/cluster/loadbalance/round_robin_test.go > 2. dubbo-go-1.1.0/common/extension/router_factory.go > 3. dubbo-go-1.1.0/config_center/configuration_parser.go > 4. dubbo-go-1.1.0/config_center/configuration_parser_test.go > 5. dubbo-go-1.1.0/registry/zookeeper/listener_test.go > 6. dubbo-go-1.1.0/cluster/loadbalance/least_active.go > 7. dubbo-go-1.1.0/protocol/RpcStatus.go > 8. dubbo-go-1.1.0/filter/impl/active_filter.go Thanks, -Ian. On Fri, Sep 6, 2019 at 6:43 AM Justin Mclean <[email protected]> wrote: > Hi, > > Great improvement over the previous release but there are still issues > from the last vote that have not been resolved. e.g. [6][7][8] > > Can someone tell me if these files [1][2][3][4][5] are just missing ASF > headers or have a different license? > > If they are just missing headers and [6][7][8] explained then it +1 form > me, otherwise it’s probably a -1. > > Can people please carefully check the contents, and write down what you > checked, rather than just saying +1. > > I checked: > - signatures and hashes good > - LICENSE is missing the appendix (not a major issue) > - LICENSE may be is missing some information[1][2][3][4][5] > - NOTICE is fine > - No binaries in source release > - Some files are missing ASF headers or other license headers > [1][2][3][4][5] - please fix > > Thanks, > Justin > > 1. dubbo-go-1.1.0/cluster/loadbalance/round_robin_test.go > 2. dubbo-go-1.1.0/common/extension/router_factory.go > 3. dubbo-go-1.1.0/config_center/configuration_parser.go > 4. dubbo-go-1.1.0/config_center/configuration_parser_test.go > 5. dubbo-go-1.1.0/registry/zookeeper/listener_test.go > 6. dubbo-go-1.1.0/cluster/loadbalance/least_active.go > 7. dubbo-go-1.1.0/protocol/RpcStatus.go > 8. dubbo-go-1.1.0/filter/impl/active_filter.go > >
