I believe there's no show stopper. Let's continue to vote the release. -Ian.
On Fri, Sep 27, 2019 at 5:16 PM victory <[email protected]> wrote: > Looking through the code I found a few other minor things that may need to > be updated: > - References to internal JIRA > http://code.alibabatech.com/jira/browse/DUBBO-XXX that I cannot access. > - Reference to this URL [2] > - Reference to this URL [3] in tests. This gives a 404 so I’m not sure if > those test pass. there are also there reference to http://dubbo.io. > > All of above problem exist for a long time and it is used for testcase. So > I think the problem can be optimized in next release. > I have posted two new issues for new release : > https://github.com/apache/dubbo/issues/5118 > https://github.com/apache/dubbo/issues/511 > <https://github.com/apache/dubbo/issues/5118>9 > > > > > Mercy <[email protected]> 于2019年9月26日周四 下午3:37写道： > > > > > > If you are the only contributor (which seems to be the case) that would > > be one way of dealing with it. The Dubbo LICENSE file would need to > change > > if that was done. > > > > Yes, I'm the only one contriubtor of this project and its LICENSE file > > has been changed to be "Apache License 2.0" : > > > > https://github.com/alibaba/spring-context-support/blob/master/LICENSE > > > > > > Is it fine? > > > > > > Kind regards, > > > > Mercy > > > > > > -- > > Best Regard! > cvitory >
