Another thing I noticed is in README for alibaba/spring-context-support it says 'An internal support project for spring-context in Alibaba'.
So I prefer to idea Ian Luo suggested, reimplement related code and remove alibaba/spring-context-support maybe a better idea On Fri, Sep 27, 2019 at 5:55 PM Justin Mclean <[email protected]> wrote: > Hi, > > > It’s strange these files have an ASF header when they are in a non ASF > repo which is licensed under a non ASF license. What the story behind these > files? > > > > The license of https://github.com/alibaba/spring-context-support < > https://github.com/alibaba/spring-context-support> had been changed to be > "Apache License 2.0" - > https://github.com/alibaba/spring-context-support/blob/master/LICENSE < > https://github.com/alibaba/spring-context-support/blob/master/LICENSE> > > That doesn’t answer my question. Why did the files have an Apache header > in a repo that was not Apache licensed? Where did these files originally > come from? It seems they were copied from somewhere to this repo and then > copied to Dubbo. > > > PR#3 says "Add some code from other places”, what other places did > this code come from? If this is the case, where other people involved in > writing that code? What license was it under? > > > > The code came from my private repo, just pulled request to > upstream(Alibaba repo). > > Sorry but neither sorry does that. At Apache all code needs clear IP > provenance, given we don’t have that here I’m still -1 on this release. Now > that -1 isn’t a veto and other PMC members may still vote +1 if they think > the IP provenance is clear. > > Thanks, > Justin
