Hi, victory
Thank you for your following. And the issue is #5186 (https://github.com/apache/dubbo/issues/5186 <https://github.com/apache/dubbo/issues/5186>) We will not need a new issue I think. And I filed two issues one of which is a resubmitted for quite an old one to mark it out that we should reach a conclusion to do or not to do. (Which was submitted by @Ianluo originally last year) best regards, Jason > On Oct 21, 2019, at 16:15, victory <[email protected]> wrote: > > I will check this problem, and I will give you reply. > If this problem is servere and urgent, I will try to fix it in a fix > version on this week. > > Jason Joo <[email protected]> 于2019年10月21日周一 下午3:26写道: > >> And I'm ok to file a NEW issue but will anyone to discuss and follow >> together? >> >> It seems that most guys are busy currently. Maybe for the event of 11.11? >> This issue would affect quite a large amount of upgraded users. >> >> An active issue needs our following up in time so we can do it better. >> >> And I also spend quite a lot of time in debugging and analyzing related >> codes to implement a multiple registries configuration. This is also >> undocumented and I feel a little buggy after trying all possible ways. >> Thank god finally we got one correct way to achieve that. >> And is this also necessary to file an issue for discussing if anyone liked >> involving in? >> >> best regards, >> >> Jason >> >>> On Oct 21, 2019, at 15:04, bailei <[email protected]> wrote: >>> >>> IMO, it is quite serve. >>> >>> Step 1: Upgrade dubbo to 2.7.4 in dubbo-samples-api. >>> Step 2: Start `org.apache.dubbo.samples.provider.Application`. Will >> report an NPE problem. >>> >>>> 在 2019年10月21日,下午2:30,victory <[email protected]> 写道: >>>> >>>> I have released dubbo-2.7.4 two days ago. >>>> If you have some problem, please file an issue on >>>> https://github.com/apache/dubbo/issues >>>> If your problem is very severe, we will try to fix in next release as >> soon >>>> as possible. >>>> >>>> Jason Joo <[email protected]> 于2019年10月21日周一 上午8:49写道: >>>> >>>>> -1. >>>>> >>>>> So will it be included in 2.7.4 or 2.7.5? >>>>> >>>>> One of our project using annotations came to introduce multiple >>>>> registries. But we found that there was a bug on subscribing same >> interface >>>>> from different registries before 2.7.3(inclusive) util #5033( >>>>> https://github.com/apache/dubbo/pull/5033) had been merged. >>>>> >>>>> But after updating to branch of 2.7.4 we continue to suffer the NPE >> issue >>>>> (Location AbstractInterfaceConfig.useRegistryForConfigIfNecessary >> which is >>>>> mentioned by @bailei). >>>>> >>>>> We will make a temporary build first in our private repository and I >>>>> suggest it is necessary being included in 2.7.4. Btw, `sonymoon` has >>>>> already given a fix in his repo ( >>>>> >> https://github.com/sonymoon/dubbo/commit/7b73f52349d7a37572bb724b28ec62e08d3a29fd >>>>> ). >>>>> >>>>> And more pls consider that how to solve the scanning problem mentioned >> in >>>>> issue #4895 (https://github.com/apache/dubbo/pull/4895) because it is >>>>> long time no response. It is not as urgent as the NPE issue. >>>>> >>>>> And I will close #4199 now and I think we'd better to describe it in >>>>> document for those which have mixed versions deployed in environment >> and >>>>> also have implemented MonitorService. (The simple solution is just >> copying >>>>> the legacy interface into project and public them together). >>>>> >>>>> best regards, >>>>> >>>>> Jason >>>>> >>>>>> On Oct 20, 2019, at 15:00, bailei <[email protected]> wrote: >>>>>> >>>>>> -1. >>>>>> I don’t know if I am qualified from voting. >>>>>> Is 2.7.4 released? >>>>>> I think there is a issue need to be checked ( >>>>> https://github.com/apache/dubbo/issues/5186 < >>>>> https://github.com/apache/dubbo/issues/5186>). Fix me if I was wrong. >>>>>> >>>>>> >>>>>>> 在 2019年10月18日,上午9:46,victory <[email protected]> 写道: >>>>>>> >>>>>>> We’ve received 3 +1 binding votes and 2 +1 non-binding vote: +1 >> binding, >>>>>>> Mercy Ma +1 binding, Justin Mclean +1 binding, Jun Liu +1 >> non-binding, >>>>> Lonre >>>>>>> Wang >>>>>>> +1 non-binding , 郑泽超 >>>>>>> >>>>>>> I will release dubbo-2.7.4 today. Best regards, The Apache Dubbo >>>>>>> (Incubating) Team >>>>>>> >>>>>>> Justin Mclean <[email protected]> 于2019年10月16日周三 上午10:58写道: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> +1 (binding) >>>>>>>> >>>>>>>> I checked: >>>>>>>> - signatures and hashes fine >>>>>>>> - LICENSE and NOTICE OK >>>>>>>> - no unexpected binary files >>>>>>>> - source files have ASF headers >>>>>>>> - can compile from source >>>>>>>> >>>>>>>> RE the software grant normally when a copyright is removed and the >>>>> headers >>>>>>>> replaced you need to put something in NOTICE saying this was done. >> If >>>>>>>> original headers are left in there then this should be mentioned in >>>>>>>> LICENSE. I suggest you fix this in the next release >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Justin >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Best Regard! >>>>>>> cvitory >>>>>> >>>>> >>>>> >>>> >>>> -- >>>> >>>> Best Regard! >>>> cvitory >> >> > > -- > > Best Regard! > cvitory
