I checked the following items. I vote +1 (binding) to this release.
[v] Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?
1.
java/dubbo-demo/dubbo-demo-api/src/main/java/org/apache/dubbo/demo/DemoProvider.java
doesn't have ASF license
2. a couple of .DS_Store files are found which should not be packaged.
Is the issue minor?
[ ] Yes [ ] No [x] Unsure
Could it possibly be fixed in the next release?
[x] Yes [ ] No [ ] Unsure
I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..
I found two minor issues which I believe they are not show-stopper and can
be fixed in the next release.
Regards,
-Ian.
On Thu, Dec 19, 2019 at 1:15 PM 胡锋 <[email protected]> wrote:
> Hello Dubbo/Dubbojs Community,
>
> This is a call for vote to release Apache dubbo-js version v3.0.0-rc2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc2/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
>
> Hash for the release tag:
> 1f8b7f0ef660186fe6ce452c57e8b1960801f005
>
> The artifacts have been signed with Key :35F44C444B811C10, which can be
> found in the keys file:
>
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
> Please vote accordingly:
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Thanks,
>
> The Apache Dubbo-js Team
>
