+1 binding I checked: * signatures and hashes are good * LICENSE and NOTICE exit and content are good * all source files no binary files
As Justin has pointed, some files do not have the right Apache License Header. I am wondering if it’s possible for this project's building tool to add some checking rules like what we do in apache/dubbo with Maven plugins[1][2]. 1. https://github.com/apache/dubbo/blob/9e9517dc2fb2892a256b8e2a0eaaadb9164b8b61/pom.xml#L354 2. https://github.com/apache/dubbo/blob/9e9517dc2fb2892a256b8e2a0eaaadb9164b8b61/pom.xml#L483 Jun > On Dec 19, 2019, at 1:15 PM, 胡锋 <[email protected]> wrote: > > Hello Dubbo/Dubbojs Community, > > This is a call for vote to release Apache dubbo-js version v3.0.0-rc2. > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc2/ > > Git tag for the release: > https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md > > Hash for the release tag: > 1f8b7f0ef660186fe6ce452c57e8b1960801f005 > > The artifacts have been signed with Key :35F44C444B811C10, which can be > found in the keys file: > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > > > Please vote accordingly: > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > Thanks, > > The Apache Dubbo-js Team
