+1 (binding) I checked: - signature and hash are fine - LICENSE and NOTICE seems OK - no unexpected binary files - source files have ASF headers - can compile from source code
The following UT case[1] failed in my environment (OpenJDK 1.8.0_222 CentOS7), but I think it will not block this release. 1.test_getMethodNames_ContainExtendsParentMethods() Thanks, Yuhao Bi Ian Luo <[email protected]> 于2020年3月9日周一 上午11:00写道： > I checked the following items. I vote +1 (binding) to this release. > > [v] Are release files in correct location? > [v] Are the digital signature and hashes correct? > [v] Do LICENSE and NOTICE files exists? > [v] Is the LICENSE and NOTICE text correct? > [v] Is the NOTICE year correct? > [x] Un-included software dependencies are not mentioned in LICENSE or > NOTICE? > [x] License information is not mentioned in NOTICE? > [x] Is there any 3rd party code contained inside the release? If so: > [ ] Does the software have a compatible license? > [ ] Are all software licenses mentioned in LICENSE? > [ ] Is the full text of the licenses (or pointers to it) in LICENSE? > Is any of this code Apache licensed? Do they have NOTICE files? If so: > [ ] Have relevant parts of those NOTICE files been added to this NOTICE > file? > [ ] Do all source files have ASF headers? > [v] Do the contents of the release match with what's tagged in version > control? > [x] Are there any unexpected binary files in the release? > [v] Can you compile from source? Are the instruction clear? > > I vote with: > [v] +1 release the software > [ ] +0 not sure if it should be released > [ ] -1 don’t release the software because.. > > Regards, > -Ian. > > > On Mon, Mar 2, 2020 at 6:10 PM Jun Liu <[email protected]> wrote: > > > Hello Dubbo Community, > > > > This is a call for vote to release Apache Dubbo version 2.6.8. > > > > The release candidates: > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.6.8/ > > > > Git tag for the release: > > https://github.com/apache/dubbo/tree/dubbo-2.6.8 > > > > Hash for the release tag: > > 5a6a069986f3627f2d50720c50024df31a3dc38a > > > > Release Notes: > > Backport some changes from 2.7 to 2.6 > > > > The artifacts have been signed with Key: 28681CB1, which can be > > found in the keys file: > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > The Apache Dubbo Team > > >
