Justin, Unless we know where that other file come from [1] I would still be -1.
For this particular file[1], it was originally authored by Song [2] and merged by Zhu [3]. It is in fact a unit test file and I am pretty sure Sun is the original author but apparently he and Zhu forgot to add ASF header in it. If you are interested in the history, you could dig into this pull request [4] and this commit [5]. I believe it should be sufficient once we follow up by adding an appropriate ASF header for this file. What do you think, Justin? Thanks, -Ian. 1. dubbo-hessian-lite-3.2.7-source-release/src/test/java/com/alibaba/com/caucho/hessian/io/writereplace/Hessian2WriteReplaceTest.java 2. https://github.com/nobodyiam 3. https://github.com/diecui1202 4. https://github.com/apache/dubbo/pull/2032 5. https://github.com/apache/dubbo-hessian-lite/commit/891c2b03 On Mon, Mar 23, 2020 at 10:50 AM Justin Mclean <[email protected]> wrote: > Hi, > > > From what I can see now, we need an NOTICE file, inside which we should > mention the codes copy of of the Caucho Hessian Project. > > The NOTICE file doesn’t need to mention that unless headers have been > removed from any files that come from Caucho Hessian, for that to happen > we would need a software grant. > > > Do you think would that change be enough for the next round of release? > > Unless we know where that other file come from [1] I would still be -1. > > Thanks, > Justin > > 1. > dubbo-hessian-lite-3.2.7-source-release/src/test/java/com/alibaba/com/caucho/hessian/io/writereplace/Hessian2WriteReplaceTest.java
