dubbo

YunKun Huang Thu, 11 Mar 2021 03:58:43 -0800

+1

but I have questions about the existing PR and issues for
apache/dubbo-spring-boot-project, how to handle them.
should we close all of them before merging happens?


On Thu, Mar 11, 2021 at 4:32 PM 一剪梅 <[email protected]> wrote:
>
> +1&nbsp;to&nbsp;merge
>
>
> 发自我的iPhone
>
> ------------------ Original ------------------
> From: ranke <[email protected]&gt;
> Date: 周四,3月 11,2021 4:31 下午
> To: dev <[email protected]&gt;
> Subject: Re: [Discuss] Merge apache/dubbo-spring-boot-project into 
> apache/dubbo
>
>
>
> ＋1 to merge
>
> 发自我的iPhone
>
>
> ------------------ Original ------------------
> From: Albumen Kevin <[email protected]&amp;gt;
> Date: Thu,Mar 11,2021 4:10 PM
> To: dev <[email protected]&amp;gt;
> Subject: Re: [Discuss] Merge apache/dubbo-spring-boot-project into 
> apache/dubbo
>
>
>
> ＋1 to merge
>
> If we merge them together, it would be more easier for users to use Dubbo
> in spring-boot env.
>
> Also, it is duplicated to publish Dubbo and dubbo-spring-boot-project for
> two times, and this will confuse users.
>
> Albumen
>
> [email protected] <[email protected]&amp;gt; 于 2021年3月11日周四 下午3:44写道：
>
> &amp;gt; +1 to merge
> &amp;gt;
> &amp;gt;
> &amp;gt;
> &amp;gt; [email protected]
> &amp;gt;
> &amp;gt; From: Gong Dewei
> &amp;gt; Date: 2021-03-11 15:42
> &amp;gt; To: dev
> &amp;gt; Subject: [Discuss] Merge apache/dubbo-spring-boot-project into 
> apache/dubbo
> &amp;gt; Hi&amp;amp;nbsp;All,
> &amp;gt;
> &amp;gt;
> &amp;gt; This discussion is about merging apache/dubbo-spring-boot-project 
> into
> &amp;gt; apache/dubbo project.
> &amp;gt;
> &amp;gt;
> &amp;gt; The code of dubbo spring-boot is relatively small[1], but its 
> processing
> &amp;gt; logic is very close to the dubbo-config-spring module. Separating 
> the two
> &amp;gt; projects is prone to version compatibility issues[2], and it also 
> increases
> &amp;gt; the work of development and testing [3].
> &amp;gt;
> &amp;gt;
> &amp;gt; The benefits of the merger can be foreseen:
> &amp;gt; 1. Simplify the testing workflow (github actions) of apache/dubbo 
> &amp;amp;amp;
> &amp;gt; apache/dubbo-samples.
> &amp;gt; 2. There is no need to release dubbo-spring-boot-* separately to 
> avoid the
> &amp;gt; problem of component version mismatch
> &amp;gt; 3. The development and testing related to dubbo spring is more 
> efficient.
> &amp;gt;
> &amp;gt;
> &amp;gt; Any ideas?
> &amp;gt;
> &amp;gt;
> &amp;gt;
> &amp;gt; [1]&amp;amp;nbsp;https://github.com/apache/dubbo-spring-boot-project
> &amp;gt; [2]&amp;amp;nbsp;https://github.com/apache/dubbo/issues/7347
> &amp;gt; [3]&amp;amp;nbsp;
> &amp;gt; 
> https://github.com/apache/dubbo/blob/master/.github/workflows/build-and-test.yml&amp;amp;nbsp;&amp;amp;nbsp
> &amp;gt; ;
> &amp;gt; &amp;amp;nbsp; &amp;amp;nbsp; &amp;amp;nbsp;
> &amp;gt; 
> https://github.com/apache/dubbo-samples/blob/master/.github/workflows/dubbo-2.yml
> &amp;gt;
> &amp;gt; &amp;amp;nbsp;Gong Dewei
> &amp;gt; &amp;amp;nbsp;
> &amp;gt;

Re: [Discuss] Merge apache/dubbo-spring-boot-project into apache/dubbo

Reply via email to