+1 to merge it back to apache/dubbo to reduce the maintenance cost. I think we can merge apache/dubbo-spring-boot-project into apache/dubbo while still keeping the apache/dubbo-spring-boot-project repo for quite a while but with its status marked as archived. In this way, we don’t need to solve all issues immediately, we can still refer to the existing issues and prs when necessary.
Jun > On Mar 12, 2021, at 10:50 AM, 龚德伟(赫炎) <[email protected]> wrote: > > I don't think it is necessary to close the issues before merging > dubbo-spring-boot-project, just follow the normal process. > > After the project is merged, its issues need to be processed and then closed, > and the new issues are added to the dubbo project. > > Gong Dewei > > > > ------------------------------------------------------------------ > 发件人：YunKun Huang <[email protected]> > 发送时间：2021年3月11日(星期四) 20:00 > 收件人：Dubbo Dev Group <[email protected]> > 抄 送：ranke <[email protected]> > 主 题：Re: [Discuss] Merge apache/dubbo-spring-boot-project into apache/dubbo > > +1 > > but I have questions about the existing PR and issues for > apache/dubbo-spring-boot-project, how to handle them. > should we close all of them before merging happens? > > On Thu, Mar 11, 2021 at 4:32 PM 一剪梅 <[email protected]> wrote: >> >> +1 to merge >> >> >> 发自我的iPhone >> >> ------------------ Original ------------------ >> From: ranke <[email protected]> >> Date: 周四,3月 11,2021 4:31 下午 >> To: dev <[email protected]> >> Subject: Re: [Discuss] Merge apache/dubbo-spring-boot-project into >> apache/dubbo >> >> >> >> ＋1 to merge >> >> 发自我的iPhone >> >> >> ------------------ Original ------------------ >> From: Albumen Kevin <[email protected]&gt; >> Date: Thu,Mar 11,2021 4:10 PM >> To: dev <[email protected]&gt; >> Subject: Re: [Discuss] Merge apache/dubbo-spring-boot-project into >> apache/dubbo >> >> >> >> ＋1 to merge >> >> If we merge them together, it would be more easier for users to use Dubbo >> in spring-boot env. >> >> Also, it is duplicated to publish Dubbo and dubbo-spring-boot-project for >> two times, and this will confuse users. >> >> Albumen >> >> [email protected] <[email protected]&gt; 于 2021年3月11日周四 下午3:44写道： >> >> &gt; +1 to merge >> &gt; >> &gt; >> &gt; >> &gt; [email protected] >> &gt; >> &gt; From: Gong Dewei >> &gt; Date: 2021-03-11 15:42 >> &gt; To: dev >> &gt; Subject: [Discuss] Merge apache/dubbo-spring-boot-project into >> apache/dubbo >> &gt; Hi&amp;nbsp;All, >> &gt; >> &gt; >> &gt; This discussion is about merging apache/dubbo-spring-boot-project >> into >> &gt; apache/dubbo project. >> &gt; >> &gt; >> &gt; The code of dubbo spring-boot is relatively small[1], but its >> processing >> &gt; logic is very close to the dubbo-config-spring module. Separating >> the two >> &gt; projects is prone to version compatibility issues[2], and it also >> increases >> &gt; the work of development and testing [3]. >> &gt; >> &gt; >> &gt; The benefits of the merger can be foreseen: >> &gt; 1. Simplify the testing workflow (github actions) of apache/dubbo >> &amp;amp; >> &gt; apache/dubbo-samples. >> &gt; 2. There is no need to release dubbo-spring-boot-* separately to >> avoid the >> &gt; problem of component version mismatch >> &gt; 3. The development and testing related to dubbo spring is more >> efficient. >> &gt; >> &gt; >> &gt; Any ideas? >> &gt; >> &gt; >> &gt; >> &gt; [1]&amp;nbsp;https://github.com/apache/dubbo-spring-boot-project >> &gt; [2]&amp;nbsp;https://github.com/apache/dubbo/issues/7347 >> &gt; [3]&amp;nbsp; >> &gt; >> https://github.com/apache/dubbo/blob/master/.github/workflows/build-and-test.yml&amp;nbsp;&amp;nbsp >> &gt; ; >> &gt; &amp;nbsp; &amp;nbsp; &amp;nbsp; >> &gt; >> https://github.com/apache/dubbo-samples/blob/master/.github/workflows/dubbo-2.yml >> &gt; >> &gt; &amp;nbsp;Gong Dewei >> &gt; &amp;nbsp; >> &gt;
