I feel your pain: it's painful to have two RCs shot down. But let's not have design discussions on a VOTE thread. Let's cancel the vote, and start a discussion in another thread. If there is an existing JIRA for this issue, please forward that; it will help us avoid going over the same old ground.
On Fri, Jul 8, 2016 at 10:01 AM, Michael Wu <[email protected]> wrote: > @ Hemanth, > > Indeed, we could have kept the tar containing only source code, without > packaged non-open-source stuffs, I know it's required by Apache policy, and > agree with the policy totally. > > However, for our project, let's just make an imagination, if we move the > jars out of the project and create the source tar, so far for voting and > consequently for releasing in the future, each time customers of the > project download the source code, they may be unable to build the project > with merely executing maven build commands, on the contrary, they have to > download and place these depended jars appropriately by themselves, isn't > it unfriendly and a super boring manner? > > Then, that's why I asked you guys who may know the use of the jars and may > give valuable suggestions for how to deal better with them, on 1 hand not > blocking future maven builds, on the other hand can make it satisfy > apache's release policy. Currently, I'm still not sure if it may bring many > additional efforts, but customer friendly seems very important to a project. > > So, could you give some details on how much the removal of jars will affect > the build? Appreciated! > > @ all, do you guys have any thought on this issue, please? We seem to have > been blocked a bit at it. Thanks. > > Michael > > Michael > > On Sat, Jul 9, 2016 at 12:21 AM, Dendukuri, Hemanth <[email protected]> > wrote: > >> Michael, Since this is voting for source only, we need to make sure only >> eagle source if voted. >> >> The artifacts should be uploaded for voting before packaging ("mvn >> package”), I believe. >> >> You can provide the instructions on how to get required tomcat jars for >> the build, if eagle has dependencies. >> >> Regards >> Hemanth >> >> >> >> >> >> >> On 7/7/16, 11:30 PM, "Michael Wu" <[email protected]> wrote: >> >> >@ Hemanth, >> > >> >Did you mean to directly remove the eagle-assembly/src/main/lib/tomcat >> >directory before packaging the source? I saw the directory removed in >> >0.3.0-incubating release, do you have any idea about the following 2: >> >1. does this removal impact building approach and behavior? >> >2. if we remove it, after "mvn package" phase, will the final jar >> assembled >> >have potential running issue with eagle-service? >> > >> >If the jars have dependencies on them, we may have to make more efforts to >> >fix it before voting RC3. >> > >> >Thanks. >> >Michael >> > >> > >> >On Fri, Jul 8, 2016 at 1:04 PM, Daniel Zhou <[email protected]> >> >wrote: >> > >> >> +1 >> >> * Built and tested successfully in centos 7 with jdk1.7 >> >> >> >> Regards, >> >> Da >> >> >> >> > On Jul 7, 2016, at 8:33 PM, Jinhu Wu <[email protected]> wrote: >> >> > >> >> > +1 >> >> > * Get the tar package and built successfully on MAC OS X with JDK >> >> 1.7(java >> >> > version "1.7.0_80") >> >> > * checked md5, sha1 successfully >> >> > * rat checked and is ok >> >> > >> >> > >> >> >> On Fri, Jul 8, 2016 at 11:03 AM, Jilin <[email protected]> wrote: >> >> >> >> >> >> +1 >> >> >> * Downloaded & built successfully on windows7 64-bit JDK 1.7 >> >> >> * md5, sha1 check passed >> >> >> * tag matches >> >> >> >> >> >> Thanks for your help >> >> >> >> >> >> 2016-07-08 10:15 GMT+08:00 Zhao Qingwen <[email protected]>: >> >> >> >> >> >>> +1 (binding) >> >> >>> >> >> >>> >> >> >>> Best Regards, >> >> >>> Qingwen Zhao | 赵晴雯 >> >> >>> >> >> >>> >> >> >>> >> >> >>> >> >> >>> 2016-07-08 8:37 GMT+08:00 Edward Zhang <[email protected]>: >> >> >>> >> >> >>>> Sorry, correct my vote from "non-binding" to "binding" :-) >> >> >>>> >> >> >>>> Thanks >> >> >>>> Edward >> >> >>>> >> >> >>>> On Thu, Jul 7, 2016 at 9:29 AM, Edward Zhang < >> [email protected] >> >> > >> >> >>>> wrote: >> >> >>>> >> >> >>>>> +1 (not-binding) >> >> >>>>> >> >> >>>>> * Downloaded & built successfully with Hotspot JDK1.7 on OSX >> >> >>>>> * Signature checked, md5, sha1 verified ( >> >> >>>>> https://httpd.apache.org/dev/verification.html) >> >> >>>>> * Apache rat:check passed (mvn apache-rat:check) >> >> >>>>> >> >> >>>>> * Commit and tag matched >> >> >>>>> >> >> >>>>> >> >> >>>>> Thanks >> >> >>>>> >> >> >>>>> Edward >> >> >>>>> >> >> >>>>> On Tue, Jul 5, 2016 at 11:04 PM, Michael Wu <[email protected]> >> >> >>> wrote: >> >> >>>>> >> >> >>>>>> Hi all, >> >> >>>>>> >> >> >>>>>> This is a release vote for Apache Eagle, version >> 0.4.0-incubating, >> >> >>>> release >> >> >>>>>> candidate 2. >> >> >>>>>> >> >> >>>>>> Highlighted changes in this release are as the following: >> >> >>>>>> * JBDC Metadata Storage Extension >> >> >>>>>> * Topology management in remote mode including start/stop/status >> >> >>>>>> operations >> >> >>>>>> * Auditlogparser for MapR's audit log >> >> >>>>>> * Oozie auditlog integration for Oozie security monitoring >> >> >>>>>> * Add applicaiton "maprFSAuditLog" >> >> >>>>>> * Refactor bin/eagle-sandbox-starter.sh to make it easier to use >> >> >>>>>> >> >> >>>>>> Thanks to everyone who has contributed to this release. >> >> >>>>>> >> >> >>>>>> Here's the release note: >> >> >> >> >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_plain;f=CHANGELOG.txt;hb=refs/heads/branch-0.4 >> >> >>>>>> >> >> >>>>>> The artifacts to be voted on are located at: >> >> >> >> >> >> https://dist.apache.org/repos/dist/dev/incubator/eagle/0.4.0-incubating-rc2/ >> >> >>>>>> >> >> >>>>>> The commit to be voted upon: >> >> >>>>>> * >> >> >> >> >> >> https://github.com/apache/incubator-eagle/commit/23d3ca604a37ccb89d7a95e5c75cfba651673b2a >> >> >>>>>> < >> >> >> >> >> >> https://github.com/apache/incubator-eagle/commit/23d3ca604a37ccb89d7a95e5c75cfba651673b2a >> >> >>>>>>> * >> >> >>>>>> >> >> >>>>>> Release tag is: >> >> >>>>>> * >> >> >> >> >> >> https://github.com/apache/incubator-eagle/releases/tag/v0.4.0-incubating-rc2 >> >> >>>>>> < >> >> >> >> >> >> https://github.com/apache/incubator-eagle/releases/tag/v0.4.0-incubating-rc2 >> >> >>>>>>> * >> >> >>>>>> >> >> >>>>>> Release artifacts are signed with the following key: >> >> >>>>>> http://people.apache.org/keys/committer/mw.asc >> >> >>>>>> >> >> >>>>>> The hashes of the artifacts are as follows: >> >> >>>>>> apache-eagle-0.4.0-incubating-src-rc2.tar.gz.md5: >> >> >>>>>> 0a78ed6c36ba57194f6721a8d6bae6f4 >> >> >>>>>> apache-eagle-0.4.0-incubating-src-rc2.tar.gz.sha1: >> >> >>>>>> f59b3d7d894181eb2019bb55f4cf6079a47339eb >> >> >>>>>> >> >> >>>>>> Please vote on releasing this package as: Apache Eagle >> >> >>> 0.4.0-incubating. >> >> >>>>>> >> >> >>>>>> The vote is open for the next 72 hours and passes if a majority >> of >> >> >> at >> >> >>>>>> least >> >> >>>>>> three +1 PPMC votes are cast. >> >> >>>>>> >> >> >>>>>> [ ] +1 Release this Apache Eagle 0.4.0-incubating Release >> Candidate >> >> >> 2. >> >> >>>>>> >> >> >>>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the >> release >> >> >>>>>> >> >> >>>>>> [ ] -1 Do not release this package because... >> >> >>>>>> >> >> >>>>>> >> >> >>>>>> Thanks. >> >> >>>>>> >> >> >>>>>> Michael >> >> >> >> >> >>
